feat: SQLite support: make migrations + tests dual-backend (pg/sqlite) #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 73.47% 73.70% +0.23%
==========================================
Files 53 57 +4
Lines 4625 4757 +132
==========================================
+ Hits 3398 3506 +108
- Misses 1227 1251 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lan17
changed the title
lan17
changed the title
lan17
changed the title
lan17
force-pushed
the
claude/add-sqlite-support-neSug
branch
from
f4d9284 to
1ba488a
Compare
SQLite is now a supported persistent backend, so migrations and DB tests must work on both PostgreSQL and SQLite without manual workarounds. - **Portable migrations**: initial revision now uses `JSONType`, `sa.func.now()`, and dialect-aware JSON path indexes so PG and SQLite can both upgrade cleanly. - **Identity alignment**: `clip_events.id` matches the model’s `Integer + Identity()` for cross-backend auto-increment. - **Alembic logging**: keep existing loggers enabled during migration runs to preserve test log capture. - **DB test reliability**: SQLite tests that span multiple engines now use a file-based DSN so schema/data persist across connections. - **Migration safety net**: added a smoke test that runs `alembic upgrade head`, compares schema vs models, and performs a basic state/event roundtrip. - **Documentation**: added a concise dual-backend migration guide and referenced it from `AGENTS.md`. - `make check` - The migration smoke test intentionally ignores SQLite’s identity-default reflection quirk and expression-index reflection warnings (SQLite limitation).
lan17
force-pushed
the
claude/add-sqlite-support-neSug
branch
from
1ba488a to
cec4b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
SQLite is now a supported persistent backend, so migrations and DB tests must work on both PostgreSQL and SQLite without manual workarounds.
What changed
JSONType,sa.func.now(), and dialect-aware JSON path indexes so PG and SQLite can both upgrade cleanly.clip_events.idmatches the model’sInteger + Identity()for cross-backend auto-increment.alembic upgrade head, compares schema vs models, and performs a basic state/event roundtrip.AGENTS.md.How to validate
make checkNotes