JMCP: Papers - jmcp/make-the-date-cutoff-a-query-parameter-UqhwXRms

[landigf]

Here's the review:

---

Review: Make date cutoff a query parameter

Change summary

• apps/web/app/feed/page.tsx: Adds since?: string to searchParams, passes it through to repository.getFeed().
• packages/db/src/index.ts: Extends the getFeed interface and DemoRepository implementation to accept since, filtering out papers with createdAt before that date.
• packages/auth/package.json / package-lock.json: Bumps drizzle-orm from ^0.44.5 to ^0.45.1 (removes duplicate nested install). Unrelated housekeeping.

Validation confidence: High

The change is small, mechanical, and follows the existing pattern (same approach as the query param). The filtering logic is straightforward.

Risks

1. No validation on since value. If a user passes ?since=garbage, new Date("garbage").getTime() returns NaN, and NaN < sinceMs is always false, so the filter silently passes everything through — effectively a no-op. This is safe but could surprise callers expecting an error. Consider adding a guard (if (sinceMs && !Number.isNaN(sinceMs))).

2. Only the DemoRepository is patched. If there's a production/SQL implementation of PapersRepository, it won't filter by since until updated. The interface is updated, so TypeScript will catch this at compile time — but confirm npm run check passes.

3. Drizzle bump is unrelated. Mixing dependency bumps with feature changes makes rollback harder. Low risk but worth noting.

4. No tests added. A unit test for the since filter on DemoRepository.getFeed would be cheap insurance, especially given the NaN edge case above.

[landigf]

Closing: will integrate valuable features directly on main to avoid cascade merge conflicts.