Skip to content

Dump format verification#83

Closed
cursor[bot] wants to merge 2 commits intomainfrom
cursor/dump-format-verification-5c37
Closed

Dump format verification#83
cursor[bot] wants to merge 2 commits intomainfrom
cursor/dump-format-verification-5c37

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor bot commented Feb 19, 2026

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.


This PR fixes two logic bugs in examples/backdrop-mysql-client/README.md where grep -v was incorrectly used for negation assertions. The previous commands always passed due to the nature of multi-line files or specific footer lines.

The changes update the grep commands to use the pattern grep <pattern> || echo $? | grep 1, which correctly asserts that a pattern is not found, aligning with existing codebase conventions for negation checks. Specifically, one fix targets the general "MariaDB dump" check, and the other refines the "Dump" check to specifically examine the header line to avoid false positives from footer lines.


AaronFeledy and others added 2 commits February 19, 2026 10:18
Tests that the backdrop recipe with MySQL 8.0 and PHP 8.4 correctly
auto-detects and installs the native MySQL client, verifying:
- MySQL client installed (not MariaDB)
- No SSL/TLS errors on connect
- bee db-export works without SSL errors
- Export uses MySQL dump format (not MariaDB dump)

This test is expected to fail until @lando/php includes the
recipe-prefixed db_client detection fix (lando/php#223).

Refs: lando/lando#3833
- Replace grep -qiv with proper negation pattern (grep -qi || echo $? | grep 1)
- Fixes bug where grep -v on multi-line files always passes
- Aligns with codebase convention from backdrop-defaults example
@cursor
Copy link
Copy Markdown
Author

cursor bot commented Feb 19, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Base automatically changed from test/mysql-client-compat to main February 19, 2026 17:09
@cursor cursor bot closed this Feb 19, 2026
@cursor
Copy link
Copy Markdown
Author

cursor bot commented Feb 19, 2026

Automatically closed this PR because it was created by Bugbot autofix for #82, and that PR was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants