Closed
Conversation
Tests that the backdrop recipe with MySQL 8.0 and PHP 8.4 correctly auto-detects and installs the native MySQL client, verifying: - MySQL client installed (not MariaDB) - No SSL/TLS errors on connect - bee db-export works without SSL errors - Export uses MySQL dump format (not MariaDB dump) This test is expected to fail until @lando/php includes the recipe-prefixed db_client detection fix (lando/php#223). Refs: lando/lando#3833
- Replace grep -qiv with proper negation pattern (grep -qi || echo $? | grep 1) - Fixes bug where grep -v on multi-line files always passes - Aligns with codebase convention from backdrop-defaults example
Author
|
Cursor Agent can help with this pull request. Just |
Author
|
Automatically closed this PR because it was created by Bugbot autofix for #82, and that PR was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.
This PR fixes two logic bugs in
examples/backdrop-mysql-client/README.mdwheregrep -vwas incorrectly used for negation assertions. The previous commands always passed due to the nature of multi-line files or specific footer lines.The changes update the
grepcommands to use the patterngrep <pattern> || echo $? | grep 1, which correctly asserts that a pattern is not found, aligning with existing codebase conventions for negation checks. Specifically, one fix targets the general "MariaDB dump" check, and the other refines the "Dump" check to specifically examine the header line to avoid false positives from footer lines.