Skip to content

Desc#19

Draft
ddudt wants to merge 7 commits intomainfrom
desc
Draft

Desc#19
ddudt wants to merge 7 commits intomainfrom
desc

Conversation

@ddudt
Copy link
Collaborator

@ddudt ddudt commented Aug 11, 2022

Adds a utility function to generate a DESC input file from a near-axis solution.

The usage is very similar to the existing utility function for VMEC: Qsc.to_desc("input_filename"), with options to pass additional input parameters specific to DESC.

@ddudt
Copy link
Collaborator Author

ddudt commented Aug 11, 2022

Still need to add testing, similar to the testing used for VMEC. This will have to wait until DESC releases compatibility with fixed-current profile inputs.

Copy link
Owner

@landreman landreman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would also be nice to have a unit test for ptolemy_identity(). (I'm away on vacation this week and next, Rogerio too, so we will be slow to respond for that time.)

@ddudt
Copy link
Collaborator Author

ddudt commented Sep 22, 2022

Fixed a few issues and started adding tests, including a unit test for ptolemy_identity(). The tests are failing because I try to import the desc module -- how do you want to handle this? Once that is resolved, we can also add tests to run the DESC equilibria as in to_vmec().

@rogeriojorge
Copy link
Collaborator

@ddudt I added an installation of DESC in CI to run all the tests there.
I also made the tests with VMEC and DESC optional using a flag "vmec_loaded" and "desc_loaded". This allows a user to run every test except the VMEC and DESC ones without an error at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants