-
Notifications
You must be signed in to change notification settings - Fork 961
feat: initial paq writeup #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Mintlify preview ID generated: preview-gowrip-1762968133-6c34622 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GowriH-1, added some suggested changes. Let me know when you have added the screenshots in to the current plaeholders.
Globally on the page, can you reinstate/use the markdown ordered numbering to "1." throughout the list because it'll render automatically.
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
|
Mintlify preview ID generated: preview-gowrip-1762974340-72173c5 |
|
Mintlify preview ID generated: preview-gowrip-1762991403-07c0af6 |
|
Mintlify preview ID generated: preview-gowrip-1762992248-dcf6848 |
katmayb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small nits, and double check the images as they're not rendering. (I think it might be the file name.)
Otherwise, awesome, LGTM!
Co-authored-by: Kathryn May <44557882+katmayb@users.noreply.github.com>
|
Mintlify preview ID generated: preview-gowrip-1763055037-4db26d9 |
|
Mintlify preview ID generated: preview-gowrip-1763057757-680a4ea |
|
Mintlify preview ID generated: preview-gowrip-1763062096-d455489 |
katmayb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GowriH-1 Take a look at the preview here: https://langchain-5e9cc07a-preview-gowrip-1763062096-d455489.mintlify.app/langsmith/annotation-queues#create-a-pairwise-annotation-queue
The screenshots are stacked and hard to differentiate. I've made two suggestions to delete two of the images anyway because I don't think they're 100% necessary.
Otherwise this LGTM!
src/langsmith/annotation-queues.mdx
Outdated
|  | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These images are stacked oddly in the preview. I would recommend deleting /langsmith/images/pairwise-annotation-queue-create-form.png I don't really think it's necessary, you've got great instructions there already (it's not adding much).
Keeping the queue-popup image makes sense, this is a bit of a different view compared to a regular annotation queue.
src/langsmith/annotation-queues.mdx
Outdated
|  | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are also stacked and hard to decipher in the rendered view.
I think you could drop one of these — the feedback-pane screenshot seems more useful.
The ALT text is also identical?
|
Mintlify preview ID generated: preview-gowrip-1763063196-3f3a4c3 |
|
Mintlify preview ID generated: preview-gowrip-1763075169-d7084f7 |
|
Mintlify preview ID generated: preview-gowrip-1763404313-26b8cbb |
Overview
Pairwise Annotation Queues
Type of change
Type:
Updating existing annotation queues with PAQ information
Related issues/PRs
Checklist
docs devsrc/docs.jsonif neededAdditional notes