INTPYTHON-816 - Bump minimum Python version to 3.10 #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
reviewed
Oct 30, 2025
| ignore_collections: Optional[List[str]] = None, | ||
| include_collections: Optional[List[str]] = None, | ||
| schema: str | None = None, | ||
| ignore_collections: List[str] | None = None, |
There was a problem hiding this comment.
I don't think we should enable this upgrade rule, it is causing a lot of unnecessary churn and likely to conflict with #208
There was a problem hiding this comment.
Sure we can turn it off.
NoahStapp
force-pushed
the
INTPYTHON-816
branch
from
8e66861 to
214797c
Compare
|
Failures are tracked in INTPYTHON-799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INTPYTHON-816
Summary
LangChain 1.0 requires Python 3.10+. Updating our own minimum version now before the package split will reduce the complexity of doing so.
Changes in this PR
Bump minimum Python version across the board to 3.10. Update ruff to the latest release for fixes such as the removal of UP038.