Open
Conversation
Owner
Author
|
A patch for triggering a crash (abort) Minimal sample: Help -> About |
Leaving wxTRY blocks with only a few lines of code as-is, but refactoring those with non-trivial amount of codelines into functions.
Add a system option to control whether the main loop and threads are run from within a try-catch block, or outside of it. Traditionally, wxWidgets has caught all unhandled C++ exceptions that are about to cause the program to be aborted. For many situations this is probably a good thing, but the downside is that it severely complicates debugging the source of such exceptions. The backtrace will only show the stack since wx's exception handler, but not where the exception occurred in the first place. Any crashdumps created by the OS also suffer from the same issue; backtraces are mostly useless in these cases. The following classes with try-catch blocks do not obey the new system option for now: wxDataViewRendererBase, wxDocTemplate, wxIDropTarget
lanurmi
force-pushed
the
dont-catch-unhandled-exceptions
branch
from
1c173a8 to
c8980d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.