[12.x] Refactor: use orderByDesc()

[amirhshokri]

This PR refactors all instances of $this->orderBy(..., 'desc') to use the more expressive $this->orderByDesc(...) method from query builder.

[shaedrich]

How long until @browner12 sends a PR reverting your changes (see #53563)?

[amirhshokri]

I didn’t get it. Why would they revert it?

@shaedrich

[browner12]

yah, don't do this. you growing the call stack and introducing a (minor) performance hit for no gain.

[amirhshokri]

Makes sense. But then why is this method in the source code?

@browner12

[shaedrich]

Because not everybody is a performance purist to the extent, browner is. And Laravel has a long history as a framework of offering convenience functions and methods.

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!