Skip to content

fix(registry): don't fallback embeddedMetaJSON to default empty JSON #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yhp20170308-dotcom wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(registry): don't fallback embeddedMetaJSON to default empty JSON #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/registry/loader_embedded.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ var embeddedMetaDataDefaultJSON []byte
func init() {
if data, err := metaFS.ReadFile("meta_data.json"); err == nil && len(data) > 0 {
embeddedMetaJSON = data
} else {
embeddedMetaJSON = embeddedMetaDataDefaultJSON
}
// When meta_data.json is not compiled in, embeddedMetaJSON remains nil,
// so hasEmbeddedData() correctly returns false and tests that depend on
// real embedded services will be skipped rather than failing.
}
Loading