feat: add claude plugin manifests and repo install docs#286
feat: add claude plugin manifests and repo install docs#286Yongbeom-Kim wants to merge 5 commits intolarksuite:mainfrom
Conversation
Separate CLI vs Claude plugin setup in the README and replace the invalid agent verification command with claude plugin list.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded Claude Code marketplace and plugin manifests ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge — all changes are additive documentation and manifest files with no logic impact. No P0 or P1 findings. The one remaining issue (missing trailing newline) is P2 style-only and does not affect functionality. Prior concerns about skill discovery and install ordering were resolved. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
actor User
participant CC as Claude Code
participant MP as Marketplace Registry
participant Repo as larksuite/cli repo
participant CLI as lark-cli binary
User->>CC: claude plugin marketplace add larksuite/cli
CC->>Repo: fetch .claude-plugin/marketplace.json
Repo-->>CC: marketplace: larksuite-cli-marketplace
CC->>MP: register marketplace
MP-->>CC: marketplace registered
User->>CC: claude plugin install larksuite/cli@larksuite-cli-marketplace
CC->>MP: resolve larksuite/cli in larksuite-cli-marketplace
MP->>Repo: fetch .claude-plugin/plugin.json + skills/
Repo-->>CC: plugin bundle (auto-discovered SKILL.md files)
CC-->>User: plugin installed
Note over User,CLI: lark-cli binary must be installed separately\n(npm install -g @larksuite/cli)
Reviews (3): Last reviewed commit: "docs: clarify AI agent comment" | Re-trigger Greptile |
| { | ||
| "name": "larksuite/cli", | ||
| "version": "1.0.4", | ||
| "description": "The official CLI for Lark/Feishu open platform", | ||
| "author": "Lark Open Platform", | ||
| "homepage": "https://github.com/larksuite/cli", | ||
| "repository": "git+https://github.com/larksuite/cli.git", | ||
| "license": "MIT", | ||
| "keywords": [ | ||
| "claude-code", | ||
| "lark", | ||
| "feishu", | ||
| "skills" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Missing skills reference in plugin manifest
This manifest contains only package metadata but has no skills array or entry field pointing to the 20+ skill files in skills/ (e.g. skills/lark-calendar/SKILL.md, skills/lark-im/SKILL.md). If the Claude Code plugin spec requires an explicit skill list for the system to know what to load, this plugin would install successfully but expose no capabilities. Please confirm whether a skills field (or equivalent) is required, or whether the plugin runtime discovers SKILL.md files by convention from the repository root.
There was a problem hiding this comment.
auto discovery is supported in the Claude plugin spec
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
66-68: Remove or clarify the installation comments; the commands are technically correct.The
claude plugin marketplace add larksuite/clicommand is valid per the Claude Code documentation—it correctly references the GitHub repository source where the marketplace is located. However, the comments "Another option, install Claude Code SKILL" and "If you are Claude Code, you can install it directly" are ambiguous and confusing. These appear to position the commands as alternatives to the required skill installation, when their relationship is unclear. Consider rephrasing for clarity, e.g., specifying whether users should use one method or whether multiple installations are needed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 66 - 68, The README contains ambiguous comments around installing the Larksuite CLI with lines "Another option, install Claude Code SKILL" and "If you are Claude Code, you can install it directly" which mislead readers about whether these commands are alternatives or required; edit the README to remove or rephrase these comments so they clearly state the relationship (e.g., "Alternative: to install via Claude Code, run:" before the two commands claude plugin marketplace add larksuite/cli and claude plugin install larksuite/cli@larksuite-cli-marketplace) and ensure the commands and their purpose (alternative vs required) are explicit and unambiguous.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 115-116: Reword the sentence to remove "directly" and clarify
target users (e.g., "If you are using Claude Code, you can install the plugin
with the following commands:"), replace the current phrasing "If you are Claude
Code, you can install it directly" with that, and then verify the two example
commands (the marketplace add and plugin install commands shown as "claude
plugin marketplace add larksuite/cli" and "claude plugin install
larksuite/cli@larksuite-cli-marketplace") match the actual Claude CLI syntax
used elsewhere in the README (fix any inconsistencies so both command examples
are correct and consistent with the earlier marketplace command usage).
---
Nitpick comments:
In `@README.md`:
- Around line 66-68: The README contains ambiguous comments around installing
the Larksuite CLI with lines "Another option, install Claude Code SKILL" and "If
you are Claude Code, you can install it directly" which mislead readers about
whether these commands are alternatives or required; edit the README to remove
or rephrase these comments so they clearly state the relationship (e.g.,
"Alternative: to install via Claude Code, run:" before the two commands claude
plugin marketplace add larksuite/cli and claude plugin install
larksuite/cli@larksuite-cli-marketplace) and ensure the commands and their
purpose (alternative vs required) are explicit and unambiguous.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e197ae26-93fb-4c25-a778-ff85b36052dc
📒 Files selected for processing (2)
README.mdREADME.zh.md
🚧 Files skipped from review as they are similar to previous changes (1)
- README.zh.md
Summary
.claude-plugin/plugin.jsonand.claude-plugin/marketplace.jsonso the repository exposes a Claude Code plugin bundleclaude plugin listfor agent verificationTest plan
.claude-plugin/plugin.json.claude-plugin/marketplace.jsonREADME.mdandREADME.zh.mdSummary by CodeRabbit
New Features
Documentation