Skip to content

MAINT: migrated code for CheckedArray/Session to use pydantic v2 #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdementen merged 4 commits into from
Nov 28, 2025
Merged

MAINT: migrated code for CheckedArray/Session to use pydantic v2 #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42d9d4f
MAINT: migrated code for CheckedArray/Session to use pydantic v2
alixdamman Nov 26, 2025
54b32f8
DOC: fixed typo
alixdamman Nov 28, 2025
ace9917
TESTS: replaced diff.x.equals(x) by diff.x is x except for member d
alixdamman Nov 28, 2025
1a2f5aa
DOC: update links to pydantic v2.12 in comments
alixdamman Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pandas >=0.20
matplotlib
tables # ==pytables
openpyxl
pydantic ==1.*
pydantic >=2.12
Copy link
Contributor

@gdementen gdementen Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually use 2.12 specific features or is it because you fear it does not work with earlier pydantic versions?

Copy link
Collaborator Author

@alixdamman alixdamman Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second option. It because you fear it does not work with earlier pydantic versions. I made changes in the code and I runned all the tests with pydantic 2.12 installed on my PC.

Copy link
Collaborator Author

@alixdamman alixdamman Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on conda (with conda search pydantic) that pydantic 2.12 is available for Python 3.9+ :

> conda search pydantic

(...)
pydantic                      2.12.2  py39haa95532_0  pkgs/main
pydantic                      2.12.3 py310haa95532_0  pkgs/main
pydantic                      2.12.3 py310haa95532_1  pkgs/main
pydantic                      2.12.3 py311haa95532_0  pkgs/main
pydantic                      2.12.3 py311haa95532_1  pkgs/main
pydantic                      2.12.3 py312haa95532_0  pkgs/main
pydantic                      2.12.3 py312haa95532_1  pkgs/main
pydantic                      2.12.3 py313haa95532_0  pkgs/main
pydantic                      2.12.3 py313haa95532_1  pkgs/main
pydantic                      2.12.3 py314haa95532_1  pkgs/main
pydantic                      2.12.4 py310haa95532_0  pkgs/main
pydantic                      2.12.4 py311haa95532_0  pkgs/main
pydantic                      2.12.4 py312haa95532_0  pkgs/main
pydantic                      2.12.4 py313haa95532_0  pkgs/main
pydantic                      2.12.4 py314haa95532_0  pkgs/main

Copy link
Contributor

@gdementen gdementen Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that check too 😉


# dependencies to actually build the documentation
sphinx ==5.3.0
Expand Down
2 changes: 2 additions & 0 deletions doc/source/changes/version_0_35.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Backward incompatible changes
will open a window and pause the running script until the window is closed by
the user. To revert to the previous behavior, use show=False.

* Using :py:obj:`CheckedSession`, :py:obj:`CheckedParameters` or :py:obj:`CheckedArray`
now requires to install pydantic >= 2.12 (closes :issue:`1075`).

New features
^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ dependencies:
- openpyxl
- xlsxwriter
- pytest >=6
- pydantic ==1.*
- pydantic >= 2.12
Loading
Loading