035issues #1145
Merged
035issues #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purposefully not including this in the changelog because I might deprecate that syntax in 0.36 (see larray-project#1142)
should also be faster for object dtypes and when rtol=0 and atol=0 and nans_equal is True
…ct#895) considered a fix because it sort of worked but silently ignored the index and name of the series
the fix I will commit next will make it more likely users see them, so we might as well make it more useful
it slowed things down in the usual case and messed some error messages
…sage (fixes larray-project#1134) * the code to compute the error message was itself raising an exception when the array key had ndim > 1 * mention the bad key parts if not too large
that should be an internal thing
* avoid useless copy of the main array when display_progress is False * avoid computing the sum on the last axis at last iteration * also added a special case for ndim == 1, but that is just to avoid breaking that corner case by the other two changes rather than making it more efficient given that it will probably never be used Overall, this makes a ~7% speed improvement for tiny test arrays. No idea for larger arrays.
instead of NotImplementedError
since I think (hope), nobody uses this, go directly to the exception step instead of a warning
…#501) in the process had to implement Axis.align(*axes), AxisCollection.align(*axis_collections) and Array.align(*arrays) also deprecated passing non (arrays or scalar) to Array.align and check that each aligned axis is either anonymous or have the same name than others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.