Sale price spatial lag configuration#296
Open
connorschwartz wants to merge 1 commit intolarsiusprime:masterfrom
Open
Sale price spatial lag configuration#296connorschwartz wants to merge 1 commit intolarsiusprime:masterfrom
connorschwartz wants to merge 1 commit intolarsiusprime:masterfrom
Conversation
The number of nearest neighbors for spatial lag calculations is configurable for other variables under process.enrich.spatial_lag.fields. Spatial lag for sale price is calculated with different code that currently is not configurable. This PR updates the code so that the sale price spatial lag calculation can be adjusted in a similar way. Also, if k is less than the number of sales in the training set, the calculation fails. So, we can instead use the minimum of k and the length of the training set.
Contributor
|
Thank you for your contribution. I affirm that this contributor has signed the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of nearest neighbors for spatial lag calculations is configurable for other variables under process.enrich.spatial_lag.fields. Spatial lag for sale price is calculated with different code that currently is not configurable. This PR updates the code so that the sale price spatial lag calculation can be adjusted in a similar way.
Also, if k is less than the number of sales in the training set, the calculation fails. So, we can instead use the minimum of k and the length of the training set.