Remove deprecated staging server and fix test for QT5 at Ubuntu 19.10#37
Open
pcgomes wants to merge 1 commit intolastfm:masterfrom
Open
Remove deprecated staging server and fix test for QT5 at Ubuntu 19.10#37pcgomes wants to merge 1 commit intolastfm:masterfrom
pcgomes wants to merge 1 commit intolastfm:masterfrom
Conversation
|
TestUrlBuilder stil fails after applaying this change: It seems all the URLs should be switched to https by default. |
kdesysadmin
pushed a commit
to KDE/amarok
that referenced
this pull request
Apr 12, 2024
liblastfm checks QCoreApplication::arguments() for "--debug". That's not easy to avoid, so add a synonym debug flag "--debug-last-fm" which has identical functionality in Amarok, but doesn't trigger the non-functional last.fm debug mode. This is not pretty, but it is pretty contained and makes reasonable last.fm bughunting possible. Should lastfm/liblastfm#37 ever get merged, this commit can be reverted, but that might not happen anytime soon as the PR has been pending for 4 years and latest liblastfm release was almost 10 years ago. BUG: 485415
pcgomes
pushed a commit
to pcgomes/amarok
that referenced
this pull request
May 5, 2024
liblastfm checks QCoreApplication::arguments() for "--debug". That's not easy to avoid, so add a synonym debug flag "--debug-last-fm" which has identical functionality in Amarok, but doesn't trigger the non-functional last.fm debug mode. This is not pretty, but it is pretty contained and makes reasonable last.fm bughunting possible. Should lastfm/liblastfm#37 ever get merged, this commit can be reverted, but that might not happen anytime soon as the PR has been pending for 4 years and latest liblastfm release was almost 10 years ago. BUG: 485415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove "staging" host if "--debug" is set. The host is wrong and setting it via "--debug" clashes with an application own debug