-
Notifications
You must be signed in to change notification settings - Fork 31
chore: adding shopify oxygen example #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0199d73 to
4b21616
Compare
|
@launchdarkly/browser size report |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
4b21616 to
842b764
Compare
2131034 to
594ef58
Compare
| }, | ||
| "type": "module", | ||
| "dependencies": { | ||
| "@launchdarkly/shopify-oxygen-sdk": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Example uses latest instead of workspace version
The example package specifies "@launchdarkly/shopify-oxygen-sdk": "latest" which fetches from npm instead of using the local workspace version. Other packages in the monorepo use "*" to reference workspace packages. This causes the example to use a published version rather than the local development version, which breaks the development workflow and could fail if the package isn't published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine? If we are only looking at this from a POV of a how-to example, then I'd argue using latest published version is probably more correct.
This PR will add an example application for Shopify Oxygen SDK
Note
Adds a Shopify Oxygen SDK example app with build/run setup and registers it in workspaces.
packages/sdk/shopify-oxygen/example):app.tsuses@shopify/mini-oxygento execute compiled worker and pollfetchoutput.src/index.tsinitializes@launchdarkly/shopify-oxygen-sdk, evaluatesvariation, flushes, and returns{ flagKey, flagValue }.package.jsonscripts (build,start) withtsupandts-node; includes dependencies and ESM config.tsconfig.jsonandtsup.config.tsfor ESM build without externalizing the SDK.README.mdwith setup and usage instructions.packages/sdk/shopify-oxygen/exampleto rootpackage.jsonworkspaces.Written by Cursor Bugbot for commit 5f0d562. This will update automatically on new commits. Configure here.