Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions e2e/dotnet4/cs/Web.config
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" />
<bindingRedirect oldVersion="0.0.0.0-11.0.0.0" newVersion="11.0.0.0" />
<bindingRedirect oldVersion="0.0.0.0-13.0.0.0" newVersion="13.0.0.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Web.Optimization" publicKeyToken="31bf3856ad364e35" />
Expand All @@ -56,15 +56,19 @@
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Web.Helpers" publicKeyToken="31bf3856ad364e35" />
<bindingRedirect oldVersion="1.0.0.0-3.0.0.0" newVersion="3.0.0.0" />
<bindingRedirect oldVersion="0.0.0.0-3.0.0.0" newVersion="3.0.0.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Web.WebPages" publicKeyToken="31bf3856ad364e35" />
<bindingRedirect oldVersion="1.0.0.0-3.0.0.0" newVersion="3.0.0.0" />
<bindingRedirect oldVersion="0.0.0.0-3.0.0.0" newVersion="3.0.0.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Web.Mvc" publicKeyToken="31bf3856ad364e35" />
<bindingRedirect oldVersion="1.0.0.0-5.2.7.0" newVersion="5.2.7.0" />
<bindingRedirect oldVersion="0.0.0.0-5.2.7.0" newVersion="5.2.7.0" />
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="OpenTelemetry.Extensions.Propagators" publicKeyToken="7bd6737fe5b67e3c" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.0.0.0" newVersion="1.0.0.0" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing binding redirects for upgraded system assemblies

High Severity

The PR upgraded System.Diagnostics.DiagnosticSource from 9.0.0 (assembly version 9.0.0.0) to 10.0.7 (assembly version 10.0.0.7) but added no binding redirect in Web.config. Packages still at 1.11.2 (OpenTelemetry, OpenTelemetry.Api.ProviderBuilderExtensions, OpenTelemetry.Exporter.OpenTelemetryProtocol, OpenTelemetry.Extensions.Hosting) were compiled against the 9.0.0.0 assembly version. At runtime on .NET Framework 4.8, the CLR will fail to resolve the old version, causing a FileLoadException. The same issue applies to System.Buffers (4.0.3.0→4.0.5.0), System.Memory (4.0.1.2→4.0.5.0), System.Numerics.Vectors (4.1.4.0→4.1.6.0), and System.Runtime.CompilerServices.Unsafe (6.0.0.0→6.0.3.0), all of which were upgraded without corresponding binding redirects.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3493215. Configure here.

</dependentAssembly>
</assemblyBinding>
</runtime>
Expand Down
39 changes: 23 additions & 16 deletions e2e/dotnet4/cs/cs.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,15 @@
</Reference>
<Reference Include="mscorlib" />
<Reference Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed">
<HintPath>..\packages/Newtonsoft.Json.13.0.1/lib/net45/Newtonsoft.Json.dll</HintPath>
<HintPath>..\packages\Newtonsoft.Json.13.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="OpenTelemetry, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c, processorArchitecture=MSIL">
<HintPath>..\packages\OpenTelemetry.1.11.2\lib\net462\OpenTelemetry.dll</HintPath>
</Reference>
<Reference Include="OpenTelemetry.Api, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c, processorArchitecture=MSIL">
<HintPath>..\packages\OpenTelemetry.Api.1.11.2\lib\net462\OpenTelemetry.Api.dll</HintPath>
<Reference Include="OpenTelemetry.Api, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c">
<HintPath>..\packages\OpenTelemetry.Api.1.15.3\lib\net462\OpenTelemetry.Api.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="OpenTelemetry.Api.ProviderBuilderExtensions, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c, processorArchitecture=MSIL">
<HintPath>..\packages\OpenTelemetry.Api.ProviderBuilderExtensions.1.11.2\lib\net462\OpenTelemetry.Api.ProviderBuilderExtensions.dll</HintPath>
Expand All @@ -144,8 +145,9 @@
<Reference Include="OpenTelemetry.Extensions.Hosting, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c, processorArchitecture=MSIL">
<HintPath>..\packages\OpenTelemetry.Extensions.Hosting.1.11.2\lib\net462\OpenTelemetry.Extensions.Hosting.dll</HintPath>
</Reference>
<Reference Include="OpenTelemetry.Extensions.Propagators, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c, processorArchitecture=MSIL">
<HintPath>..\packages\OpenTelemetry.Extensions.Propagators.1.9.0\lib\net462\OpenTelemetry.Extensions.Propagators.dll</HintPath>
<Reference Include="OpenTelemetry.Extensions.Propagators, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c">
<HintPath>..\packages\OpenTelemetry.Extensions.Propagators.1.15.3\lib\net462\OpenTelemetry.Extensions.Propagators.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="OpenTelemetry.Instrumentation.AspNet, Version=1.11.0.339, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c, processorArchitecture=MSIL">
<HintPath>..\packages\OpenTelemetry.Instrumentation.AspNet.1.11.0-beta.1\lib\net462\OpenTelemetry.Instrumentation.AspNet.dll</HintPath>
Expand Down Expand Up @@ -211,13 +213,15 @@
<HintPath>..\packages\StackExchange.Redis.2.6.122\lib\net472\StackExchange.Redis.dll</HintPath>
</Reference>
<Reference Include="System" />
<Reference Include="System.Buffers, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
<HintPath>..\packages\System.Buffers.4.5.1\lib\net461\System.Buffers.dll</HintPath>
<Reference Include="System.Buffers, Version=4.0.5.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51">
<HintPath>..\packages\System.Buffers.4.6.1\lib\net462\System.Buffers.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.ComponentModel.Composition" />
<Reference Include="System.Data" />
<Reference Include="System.Diagnostics.DiagnosticSource, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
<HintPath>..\packages\System.Diagnostics.DiagnosticSource.9.0.0\lib\net462\System.Diagnostics.DiagnosticSource.dll</HintPath>
<Reference Include="System.Diagnostics.DiagnosticSource, Version=10.0.0.7, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51">
<HintPath>..\packages\System.Diagnostics.DiagnosticSource.10.0.7\lib\net462\System.Diagnostics.DiagnosticSource.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Drawing" />
<Reference Include="System.IO, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
Expand All @@ -229,8 +233,9 @@
<Reference Include="System.IO.Pipelines, Version=5.0.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
<HintPath>..\packages\System.IO.Pipelines.5.0.1\lib\net461\System.IO.Pipelines.dll</HintPath>
</Reference>
<Reference Include="System.Memory, Version=4.0.1.2, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
<HintPath>..\packages\System.Memory.4.5.5\lib\net461\System.Memory.dll</HintPath>
<Reference Include="System.Memory, Version=4.0.5.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51">
<HintPath>..\packages\System.Memory.4.6.3\lib\net462\System.Memory.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Net.Http, Version=4.1.1.3, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Net.Http.4.3.4\lib\net46\System.Net.Http.dll</HintPath>
Expand All @@ -239,14 +244,16 @@
<HintPath>..\packages\System.Net.Http.WinHttpHandler.7.0.0\lib\net462\System.Net.Http.WinHttpHandler.dll</HintPath>
</Reference>
<Reference Include="System.Numerics" />
<Reference Include="System.Numerics.Vectors, Version=4.1.4.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Numerics.Vectors.4.5.0\lib\net46\System.Numerics.Vectors.dll</HintPath>
<Reference Include="System.Numerics.Vectors, Version=4.1.6.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
<HintPath>..\packages\System.Numerics.Vectors.4.6.1\lib\net462\System.Numerics.Vectors.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Runtime, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Runtime.4.3.0\lib\net462\System.Runtime.dll</HintPath>
</Reference>
<Reference Include="System.Runtime.CompilerServices.Unsafe, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Runtime.CompilerServices.Unsafe.6.0.0\lib\net461\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
<Reference Include="System.Runtime.CompilerServices.Unsafe, Version=6.0.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
<HintPath>..\packages\System.Runtime.CompilerServices.Unsafe.6.1.2\lib\net462\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="System.Runtime.InteropServices.RuntimeInformation, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\packages\System.Runtime.InteropServices.RuntimeInformation.4.0.0\lib\net45\System.Runtime.InteropServices.RuntimeInformation.dll</HintPath>
Expand Down Expand Up @@ -420,4 +427,4 @@
</Target>
<Target Name="AfterBuild">
</Target> -->
</Project>
</Project>
58 changes: 29 additions & 29 deletions e2e/dotnet4/cs/packages.config
Original file line number Diff line number Diff line change
@@ -1,51 +1,63 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Antlr" version="3.5.0.2" targetFramework="net48" />
<package id="bootstrap" version="3.4.1" targetFramework="net48" />
<package id="elmah.corelibrary" version="1.2.2" targetFramework="net48" />
<package id="Elmah.Io.AspNet" version="5.1.47" targetFramework="net48" />
<package id="Elmah.Io.Client" version="5.1.76" targetFramework="net48" />
<package id="Elmah.Io.Mvc" version="5.1.47" targetFramework="net48" />
<package id="Elmah.Mvc" version="2.1.2" targetFramework="net48" />
<package id="Grpc.Net.Client" version="2.62.0" targetFramework="net48" />
<package id="Grpc.Net.Common" version="2.62.0" targetFramework="net48" />
<package id="Highlight.ASP4" version="0.2.7" targetFramework="net48" />
<package id="Microsoft.Extensions.Configuration.Binder" version="9.0.0" targetFramework="net48" />
<package id="Google.Protobuf" version="3.26.1" targetFramework="net48" />
<package id="Grpc" version="2.44.0" targetFramework="net48" />
<package id="Grpc.Core" version="2.44.0" targetFramework="net48" />
<package id="Grpc.Core.Api" version="2.62.0" targetFramework="net48" />
<package id="Grpc.Net.Client" version="2.62.0" targetFramework="net48" />
<package id="Grpc.Net.Common" version="2.62.0" targetFramework="net48" />
<package id="Highlight.ASP4" version="0.2.7" targetFramework="net48" />
<package id="jQuery" version="3.5.0" targetFramework="net48" />
<package id="jQuery.Validation" version="1.19.4" targetFramework="net48" />
<package id="Microsoft.AspNet.Mvc" version="5.2.7" targetFramework="net48" />
<package id="Microsoft.AspNet.Razor" version="3.2.7" targetFramework="net48" />
<package id="Microsoft.AspNet.Web.Optimization" version="1.1.3" targetFramework="net48" />
<package id="Microsoft.AspNet.WebPages" version="3.2.7" targetFramework="net48" />
<package id="Microsoft.Bcl.AsyncInterfaces" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" version="2.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Configuration" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Configuration.Abstractions" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Configuration.Binder" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.DependencyInjection" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.DependencyInjection.Abstractions" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Diagnostics.Abstractions" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Hosting.Abstractions" version="9.0.0" targetFramework="net48" />
<package id="OpenTelemetry.Extensions.Hosting" version="1.11.2" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.EntityFrameworkCore" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.StackExchangeRedis" version="1.11.0-beta.1" targetFramework="net48" />
<package id="Serilog.Sinks.OpenTelemetry" version="4.1.1" targetFramework="net48" />
<package id="Microsoft.Extensions.FileProviders.Abstractions" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Hosting.Abstractions" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Logging" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Logging.Abstractions" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Logging.Configuration" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Options" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Options.ConfigurationExtensions" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.Extensions.Primitives" version="9.0.0" targetFramework="net48" />
<package id="Microsoft.jQuery.Unobtrusive.Validation" version="3.2.11" targetFramework="net48" />
<package id="Microsoft.Web.Infrastructure" version="1.0.0.0" targetFramework="net48" />
<package id="Modernizr" version="2.8.3" targetFramework="net48" />
<package id="Newtonsoft.Json" version="13.0.1" targetFramework="net48" />
<package id="OpenTelemetry" version="1.11.2" targetFramework="net48" />
<package id="OpenTelemetry.Api" version="1.11.2" targetFramework="net48" />
<package id="OpenTelemetry.Api" version="1.15.3" targetFramework="net48" />
<package id="OpenTelemetry.Api.ProviderBuilderExtensions" version="1.11.2" targetFramework="net48" />
<package id="OpenTelemetry.Exporter.Console" version="1.9.0" targetFramework="net48" />
<package id="OpenTelemetry.Exporter.OpenTelemetryProtocol" version="1.11.2" targetFramework="net48" />
<package id="OpenTelemetry.Exporter.Zipkin" version="1.9.0" targetFramework="net48" />
<package id="OpenTelemetry.Extensions.Propagators" version="1.9.0" targetFramework="net48" />
<package id="OpenTelemetry.Extensions.Hosting" version="1.11.2" targetFramework="net48" />
<package id="OpenTelemetry.Extensions.Propagators" version="1.15.3" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.AspNet" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.EntityFrameworkCore" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.GrpcNetClient" version="1.9.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.Http" version="1.11.0" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.Process" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.Quartz" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.Runtime" version="1.11.0" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.SqlClient" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.StackExchangeRedis" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Instrumentation.Wcf" version="1.11.0-beta.1" targetFramework="net48" />
<package id="OpenTelemetry.Resources.Azure" version="1.0.0-beta.8" targetFramework="net48" />
<package id="OpenTelemetry.Resources.Host" version="0.1.0-beta.2" targetFramework="net48" />
Expand All @@ -55,19 +67,20 @@
<package id="OpenTracing" version="0.12.1" targetFramework="net48" />
<package id="Pipelines.Sockets.Unofficial" version="2.2.8" targetFramework="net48" />
<package id="Serilog" version="4.2.1-dev-02340" targetFramework="net48" />
<package id="Serilog.Sinks.OpenTelemetry" version="4.1.1" targetFramework="net48" />
<package id="StackExchange.Redis" version="2.6.122" targetFramework="net48" />
<package id="System.Buffers" version="4.5.1" targetFramework="net48" />
<package id="System.Diagnostics.DiagnosticSource" version="9.0.0" targetFramework="net48" />
<package id="System.Buffers" version="4.6.1" targetFramework="net48" />
<package id="System.Diagnostics.DiagnosticSource" version="10.0.7" targetFramework="net48" />
<package id="System.IO" version="4.3.0" targetFramework="net48" />
<package id="System.IO.Compression" version="4.3.0" targetFramework="net48" />
<package id="System.IO.Pipelines" version="5.0.1" targetFramework="net48" />
<package id="System.Memory" version="4.5.5" targetFramework="net48" />
<package id="System.Memory" version="4.6.3" targetFramework="net48" />
<package id="System.Net.Http" version="4.3.4" targetFramework="net48" />
<package id="System.Net.Http.WinHttpHandler" version="7.0.0" targetFramework="net48" />
<package id="System.Numerics.Vectors" version="4.5.0" targetFramework="net48" />
<package id="System.Numerics.Vectors" version="4.6.1" targetFramework="net48" />
<package id="System.Reflection.Emit.Lightweight" version="4.7.0" targetFramework="net48" />
<package id="System.Runtime" version="4.3.0" targetFramework="net48" />
<package id="System.Runtime.CompilerServices.Unsafe" version="6.0.0" targetFramework="net48" />
<package id="System.Runtime.CompilerServices.Unsafe" version="6.1.2" targetFramework="net48" />
<package id="System.Runtime.InteropServices.RuntimeInformation" version="4.0.0" targetFramework="net48" />
<package id="System.Security.Cryptography.Algorithms" version="4.3.0" targetFramework="net48" />
<package id="System.Security.Cryptography.Encoding" version="4.3.0" targetFramework="net48" />
Expand All @@ -78,18 +91,5 @@
<package id="System.Threading.Channels" version="8.0.0" targetFramework="net48" />
<package id="System.Threading.Tasks.Extensions" version="4.5.4" targetFramework="net48" />
<package id="System.ValueTuple" version="4.5.0" targetFramework="net48" />
<package id="bootstrap" version="3.4.1" targetFramework="net48" />
<package id="elmah.corelibrary" version="1.2.2" targetFramework="net48" />
<package id="jQuery" version="3.5.0" targetFramework="net48" />
<package id="jQuery.Validation" version="1.19.4" targetFramework="net48" />
<package id="Microsoft.AspNet.Mvc" version="5.2.7" targetFramework="net48" />
<package id="Microsoft.AspNet.Razor" version="3.2.7" targetFramework="net48" />
<package id="Microsoft.AspNet.Web.Optimization" version="1.1.3" targetFramework="net48" />
<package id="Microsoft.AspNet.WebPages" version="3.2.7" targetFramework="net48" />
<package id="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" version="2.0.0" targetFramework="net48" />
<package id="Microsoft.jQuery.Unobtrusive.Validation" version="3.2.11" targetFramework="net48" />
<package id="Microsoft.Web.Infrastructure" version="1.0.0.0" targetFramework="net48" />
<package id="Modernizr" version="2.8.3" targetFramework="net48" />
<package id="Newtonsoft.Json" version="13.0.1" targetFramework="net48" />
<package id="WebGrease" version="1.6.0" targetFramework="net48" />
</packages>
Loading