Skip to content

fix: Improve escaping for curl event publisher #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 20, 2025
Merged

fix: Improve escaping for curl event publisher #230

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3309a6f
fix: Escape all headers in curl event publisher
keelerm84 Nov 20, 2025
133cf04
Add some additional escaping
keelerm84 Nov 20, 2025
22d80be
remove full shell escape
keelerm84 Nov 20, 2025
6432299
remove window escape
keelerm84 Nov 20, 2025
a1f6ca3
escape curl command
keelerm84 Nov 20, 2025
4e25442
windows escaping
keelerm84 Nov 20, 2025
f01f306
Use strval of header value
keelerm84 Nov 20, 2025
d7efa8f
debugging
keelerm84 Nov 20, 2025
60121a3
adjustment
keelerm84 Nov 20, 2025
a5b4711
remove debugging
keelerm84 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/LaunchDarkly/Impl/Integrations/CurlEventPublisher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,7 @@ private function createCurlArgs(string $payload): string
$args.= " --max-time " . $this->_timeout;

foreach ($this->_eventHeaders as $key => $value) {
if ($key == 'Authorization') {
$args.= " -H " . escapeshellarg("Authorization: " . $value);
} else {
$args.= " -H '$key: $value'";
}
$args.= " -H " . escapeshellarg("$key: $value");
}

$args.= " -d " . escapeshellarg($payload);
Expand Down