Skip to content

ci: split release-please into independent release and PR creation steps #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keelerm84 wants to merge 1 commit into from
Closed

ci: split release-please into independent release and PR creation steps #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 64 additions & 1 deletion .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,71 @@ jobs:
package-server-ai-optimization-released: ${{ steps.release.outputs['packages/optimization--release_created'] }}
package-server-ai-optimization-tag-name: ${{ steps.release.outputs['packages/optimization--tag_name'] }}
steps:
- uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4
# Create any releases first, then create tags, and then optionally create any new PRs.
- uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4.4.0
id: release
with:
skip-github-pull-request: true

# Need the repository content to be able to create and push tags.
- uses: actions/checkout@v4
if: >-
steps.release.outputs['packages/sdk/server-ai--release_created'] == 'true' ||
steps.release.outputs['packages/ai-providers/server-ai-langchain--release_created'] == 'true' ||
steps.release.outputs['packages/ai-providers/server-ai-openai--release_created'] == 'true' ||
steps.release.outputs['packages/optimization--release_created'] == 'true'

- name: Create release tags
if: >-
steps.release.outputs['packages/sdk/server-ai--release_created'] == 'true' ||
steps.release.outputs['packages/ai-providers/server-ai-langchain--release_created'] == 'true' ||
steps.release.outputs['packages/ai-providers/server-ai-openai--release_created'] == 'true' ||
steps.release.outputs['packages/optimization--release_created'] == 'true'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SERVER_AI_TAG: ${{ steps.release.outputs['packages/sdk/server-ai--tag_name'] }}
LANGCHAIN_TAG: ${{ steps.release.outputs['packages/ai-providers/server-ai-langchain--tag_name'] }}
OPENAI_TAG: ${{ steps.release.outputs['packages/ai-providers/server-ai-openai--tag_name'] }}
OPTIMIZATION_TAG: ${{ steps.release.outputs['packages/optimization--tag_name'] }}
SERVER_AI_RELEASED: ${{ steps.release.outputs['packages/sdk/server-ai--release_created'] }}
LANGCHAIN_RELEASED: ${{ steps.release.outputs['packages/ai-providers/server-ai-langchain--release_created'] }}
OPENAI_RELEASED: ${{ steps.release.outputs['packages/ai-providers/server-ai-openai--release_created'] }}
OPTIMIZATION_RELEASED: ${{ steps.release.outputs['packages/optimization--release_created'] }}
run: |
git config user.name "github-actions[bot]"
git config user.email "github-actions[bot]@users.noreply.github.com"

for pair in \
"${SERVER_AI_RELEASED}:${SERVER_AI_TAG}" \
"${LANGCHAIN_RELEASED}:${LANGCHAIN_TAG}" \
"${OPENAI_RELEASED}:${OPENAI_TAG}" \
"${OPTIMIZATION_RELEASED}:${OPTIMIZATION_TAG}"; do

RELEASED="${pair%%:*}"
TAG="${pair#*:}"

if [ "${RELEASED}" != "true" ] || [ -z "${TAG}" ]; then
continue
fi

if gh api "repos/${{ github.repository }}/git/ref/tags/${TAG}" >/dev/null 2>&1; then
echo "Tag ${TAG} already exists, skipping creation."
else
echo "Creating tag ${TAG}."
git tag "${TAG}"
git push origin "${TAG}"
fi
done

- uses: googleapis/release-please-action@16a9c90856f42705d54a6fda1823352bdc62cf38 # v4.4.0
if: >-
steps.release.outputs['packages/sdk/server-ai--release_created'] != 'true' &&
steps.release.outputs['packages/ai-providers/server-ai-langchain--release_created'] != 'true' &&
steps.release.outputs['packages/ai-providers/server-ai-openai--release_created'] != 'true' &&
steps.release.outputs['packages/optimization--release_created'] != 'true'
Copy link
Copy Markdown

@cursor cursor Bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monorepo PR creation skipped on partial release

Medium Severity

The second-pass condition uses && across all four release_created != 'true' checks, so if even one package releases, the entire PR-creation step is skipped. In this monorepo, the first pass has skip-github-pull-request: true, meaning it never creates or updates release PRs at all. When a subset of packages release (e.g. only server-ai), the remaining packages (langchain, openai, optimization) that have pending changes will not get their release PRs created or updated in that run — they must wait until the next push to main where no package releases, potentially stalling their release cycle.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 26d0727. Configure here.

id: release-prs
with:
skip-github-release: true

release-server-ai:
runs-on: ubuntu-latest
Expand Down
Loading