fix!: Swap track_metrics_of parameter order to match spec#144
Merged
jsonbailey merged 1 commit intomainfrom Apr 27, 2026
Merged
fix!: Swap track_metrics_of parameter order to match spec#144jsonbailey merged 1 commit intomainfrom
jsonbailey merged 1 commit intomainfrom
Conversation
Spec requirement 1.1.14.1 defines metrics_extractor as the first parameter and the operation callable as the second. The previous implementation had them reversed. This is a breaking change for any callers passing positional arguments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
keelerm84
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
track_metrics_ofandtrack_metrics_of_asyncso thatmetrics_extractoris first and the operation callable (func) is second, matching spec requirement AITRACK 1.1.14.1managed_agent.py,managed_model.py,judge/__init__.py)test_tracker.pyBreaking change
Any caller passing positional arguments to
track_metrics_ofortrack_metrics_of_asyncmust swap their argument order.Test plan
test_tracker.pyupdated and passCloses AIC-2378
🤖 Generated with Claude Code
Note
Medium Risk
Breaking API change for any callers using positional arguments to
track_metrics_of/track_metrics_of_async; incorrect ordering would fail at runtime or mis-track metrics.Overview
Aligns the public tracking API with the spec by swapping argument order for
LDAIConfigTracker.track_metrics_ofandtrack_metrics_of_asyncsometrics_extractorcomes first and the operation callable comes second.Updates internal invocation sites in
ManagedModel,ManagedAgent, andJudge, and adjuststest_tracker.pyto use the new positional order.Reviewed by Cursor Bugbot for commit 0392d8c. Bugbot is set up for automated code reviews on this repo. Configure here.