Fix temp-column/shard eviction race: 1s minimum item lifetime + atomic LRU#11
Open
Fix temp-column/shard eviction race: 1s minimum item lifetime + atomic LRU#11
Conversation
…c LRU Cherry-picked Go storage changes from c988df4 (without queryplan.scm changes): - cache.go: add registeredAt int64 to softItem; evict() skips items <1s old - scan_helper.go: touchTempColumns refreshes ALL temp columns of scanned table - shard.go / partition.go / database.go / storage.go / index.go: change storageShard.lastAccessed from time.Time to uint64 UnixNano with atomic.LoadUint64/StoreUint64 everywhere, removing the data race Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of the Go storage fixes from c988df4, without the queryplan.scm scalar-subquery changes.
registeredAt int64tosoftItem;evict()skips any item whosemax(registeredAt, lastUsed)is less than 1s old — guarantees minimum lifetime for every cached itemtouchTempColumnsnow refreshes all temp columns of the scanned table (not just those in the scan's column lists), preventing concurrent eviction during an active scanstorageShard.lastAccessedfromtime.Time(non-atomic 24-byte struct) touint64UnixNano withatomic.LoadUint64/StoreUint64everywhere — removes the data race onshardLastUsed()/indexLastUsed()/keytableLastUsed()Test plan
🤖 Generated with Claude Code