Skip to content

CheckPoint1 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lawerenceWilliams wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

CheckPoint1 #6

lawerenceWilliams wants to merge 5 commits into from

Conversation

@lawerenceWilliams
Copy link
Owner

@lawerenceWilliams lawerenceWilliams commented Oct 28, 2018

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

reneemeyer
reneemeyer reviewed Dec 10, 2018
View reviewed changes
Copy link

@reneemeyer reneemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, see comments below

03week/towersOfHanoi.js
// Checking to see if one block is larger than the other for valid move
const grabLast = stacks[startStack].slice(-1)
const compareWhereGoing = stacks[endStack].slice(-1)
if(grabLast < compareWhereGoing || compareWhereGoing === undefined){
Copy link

@reneemeyer reneemeyer Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplify and just return the evaluation

return !compareWhereGoing || grabLast < compareWhereGoing

03week/towersOfHanoi.js
function checkForWin() {
// Your code here
// C in quotes to access the array and 4 is the lenght of the pieces needed to Win
return (stacks['c'].length == 4);
Copy link

@reneemeyer reneemeyer Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parentheses are unnecessary

03week/towersOfHanoi.js

// Function To Reset Game
const resetGame=()=>{
return stacks;
Copy link

@reneemeyer reneemeyer Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't reset anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@reneemeyer reneemeyer reneemeyer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lawerenceWilliams @reneemeyer