Draft
Conversation
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add minio for OSS unit tests
Add MinIO for OSS unit tests
Nov 11, 2025
Member
|
@copilot ci fail /usr/bin/docker pull bitnami/minio:latest
Error response from daemon: manifest for bitnami/minio:latest not found: manifest unknown: manifest unknown
Warning: Docker pull failed with exit code 1, back off 8.84 seconds before retry.
/usr/bin/docker pull bitnami/minio:latest
Error response from daemon: manifest for bitnami/minio:latest not found: manifest unknown: manifest unknown
Warning: Docker pull failed with exit code 1, back off 8.207 seconds before retry.
/usr/bin/docker pull bitnami/minio:latest
Error response from daemon: manifest for bitnami/minio:latest not found: manifest unknown: manifest unknown
Error: Docker pull failed with exit code 1 |
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
Author
fengmk2
reviewed
Nov 12, 2025
test/unit/client/Oss.test.ts
Outdated
| const hello = await client.oss.put({ | ||
| storeName: 'oss_demo', | ||
| bucket: 'antsys-tnpmbuild', | ||
| bucket: 'layotto-test-bucket', |
Member
There was a problem hiding this comment.
@copilot Do not change the default value; the CI environment passes the bucket name through environment variables.
Author
There was a problem hiding this comment.
Reverted in commit fd3544f. The bucket name is now back to antsys-tnpmbuild as the default value. The setup script also creates this bucket name. Tests are still enabled (removed describe.skip).
Co-authored-by: fengmk2 <156269+fengmk2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OSS (Object Storage Service) unit tests were disabled (
describe.skip) due to dependency on an external bucketantsys-tnpmbuild. This PR adds local MinIO infrastructure to enable these tests.Changes
Infrastructure
docker-compose.yml: Added MinIO service (minio/minio:latest) on ports 9000/9001.github/workflows/nodejs.yml: MinIO started viadocker runcommand in setup step (using official minio/minio:latest image)scripts/setup-minio.sh: Automated bucket creation script using MinIO clientConfiguration
demo/config.json: Added file store configuration pointing to localhost MinIO instanceTests
test/unit/client/Oss.test.ts: Enabled 19 test cases, kept original bucket nameantsys-tnpmbuild(CI can override via environment variables)Usage
# Local development docker-compose up -d bash scripts/setup-minio.sh npm run test:unitThe setup script waits for MinIO readiness, installs the mc client, and creates the
antsys-tnpmbuildbucket automatically.Original prompt
<issue_description>>
What would you like to be added:
Why is this needed:</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.