Feature request: peptide position information in results#223
Feature request: peptide position information in results#223mansanlab wants to merge 1 commit intolazear:masterfrom
Conversation
lazear
left a comment
lazear
left a comment
There was a problem hiding this comment.
Tbh I don't really like the idea of adding these columns:
- Unclear how or if this interacts with new protein grouping module
- Unclear what the value is, especially considering that:
- These are trivial to compute by the end user
| vec![ | ||
| "psm_id", | ||
| "peptide", | ||
| "first_aa", |
There was a problem hiding this comment.
"first_aa" and "last_aa" seem tautological, and trivially computable for end users
| start: Instant, | ||
| } | ||
|
|
||
| fn feature_headers() -> Vec<&'static str> { |
There was a problem hiding this comment.
What's the rationale for lifting these to functions?
There was a problem hiding this comment.
Had to fight the borrow-checker less this way, but I know there are simpler ways to do this.
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { |
There was a problem hiding this comment.
I am generally in favor of tests, but these seem unnecessary
| required byte_array scannr (utf8); | ||
| required byte_array peptide (utf8); | ||
| required byte_array stripped_peptide (utf8); | ||
| required byte_array first_aa (utf8); |
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { |
|
The value personally comes entirely from next_aa, prev_aa, starts, and ends; all others come for "free". I included them to be pedantic and it would be easier to remove than to add them later should you (or others) find these useful. I use next_aa, prev_aa, starts, and ends for mapping semi-tryptic peptide sites to structure and to determine the semi-tryptic ended-ness; N-term vs C-term semi-enzymatic cleavage. |
2 participants
Fixes #110