Refactor: Modularize PokemonDetail CSS and add documentation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 17, 2026 13:21
- fixed grid dimensions and cards size
…er Formulary ->Reutilizable labels and buttons
…ty, added swap turn functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #4 by refactoring the
PokemonDetailcomponent. I have extracted the embedded/parent styles into a dedicated CSS file to improve code readability and maintainability. I also added JSDoc comments to explain the component's logic.Changes Made
src/screens/selection/PokemonDetail.css: Moved all Gameboy-related styles (modal, bezel, screen, buttons) into this new file.src/screens/selection/PokemonDetail.js:src/screens/selection/SelectionScreen.css: Removed the duplicate Gameboy/Modal styles to prevent conflicts.Closes #4