Skip to content

Minor changes#15

Open
rarylson wants to merge 7 commits intolbenitez000:masterfrom
rarylson:minor-changes
Open

Minor changes#15
rarylson wants to merge 7 commits intolbenitez000:masterfrom
rarylson:minor-changes

Conversation

@rarylson
Copy link

@rarylson rarylson commented Mar 8, 2020

Minor changes:

  • Improvements in the README doccumentation
  • Some small refactors

rarylson added 7 commits March 8, 2020 11:29
It makes sense, since Python2 is now deprecated.

See: https://www.python.org/doc/sunset-python-2/
Just to follow the pattern used in the project (there are lot's of other
lines using `format`).
A traceroute output can start from a hop number different from 1 (this
happens when using `traceroute -f FIRST_TTL`).
To be consistent with changes in v0.3.0.
@deajan
Copy link

deajan commented Apr 21, 2020

Hi,

I'm currently working on a traceroute historizer, that uses trparse to compare traceroutes with earlier runs and only save different ones.

I've decided to make some modifications to the code, adding windows support among others.

I've looked accros a couple of your commits, and noticed that you say that hops may not start with 1. Can you elaborate please ?

@rarylson
Copy link
Author

rarylson commented May 2, 2020

@deajan 👍

-f first_ttl
Specifies with what TTL to start. Defaults to 1.

➜  ~ traceroute -f 2 google.com
traceroute to google.com (172.217.172.206), 128 hops max, 52 byte packets
 2  broadcom.home (192.168.15.1)  2.197 ms  2.135 ms  1.824 ms
 3  * * *
 4  187-100-163-68.dsl.telesp.net.br (187.100.163.68)  25.645 ms
    187-100-163-70.dsl.telesp.net.br (187.100.163.70)  6.118 ms
    187-100-163-68.dsl.telesp.net.br (187.100.163.68)  4.938 ms
 5  187-100-34-129.dsl.telesp.net.br (187.100.34.129)  4.338 ms
    187-100-169-14.dsl.telesp.net.br (187.100.169.14)  4.702 ms  3.881 ms
 6  209.85.172.178 (209.85.172.178)  5.028 ms
    72.14.194.130 (72.14.194.130)  5.043 ms  5.121 ms

Ref: https://linux.die.net/man/8/traceroute

@deajan
Copy link

deajan commented May 3, 2020

Thanks for that ;)
Indeed I'll have to update my traceroute diff code to handle those cases.
Btw, I'll probably ask @lbenitez000 to take maintainership over trparse (if he does not want to invest more time) since it will be the basis of my https://github.com/deajan/traceroute_history project.

Are there any code changes other than this PR that you would like to see merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants