[Bugfix] Use four instead of one ResourceSet in performance benchmark#1
Open
dstrueber wants to merge 1 commit intolbeurerkellner:masterfrom
Open
[Bugfix] Use four instead of one ResourceSet in performance benchmark#1dstrueber wants to merge 1 commit intolbeurerkellner:masterfrom
dstrueber wants to merge 1 commit intolbeurerkellner:masterfrom
Conversation
In the unfixed version, the performance benchmark loads each of the four pair of metamodels into the same resource set (within the "getModel()" method). This appears to violate a global assumption of EMF: ResourceSet.getPackageRegistry().getEPackage(nsURI) returns a single package, and not a list of packages. Since my code relies on this global assumption, I submit a fix, which ensures that each pair of metamodels (together with the instances) is loaded into a separate ResourceSet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the unfixed version, the performance benchmark loads each of the four pairs of metamodels into the same resource set (within the "getModel()" method). The problem is that the metamodels have the same namespace URIs over the different scenarios, violating a global assumption of EMF: ResourceSet.getPackageRegistry().getEPackage(nsURI) returns a single package, and not a list of packages. Since my code relies on this global assumption, I submit a fix, which ensures that each pair of metamodels (together with the instances) is loaded into a separate ResourceSet.