Arduino v3.x support #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conditionally defines things like IPADDR_NONE which were previously included in an upstream dependency in Arduino v2.x, but now are missing. This allows for the use of the library in both the 2.x and 3.x versions of the Arduino framework for ESP32.
lbussy
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the changes coming with Arduino 3.x is that the lwip headers are no longer included by one of the upstream dependencies, resulting in there not being defines for things like IPADDR_NONE and IPADDR_LOOPBACK. This conditionally adds those defines.
An alternative implementation would be to do
#include <ip4_addr.h>in LCBUrl.cpp where I have included the conditional defines.