feat: add native OS notifications with configurable trigger modes#34
Open
BennettSchwartz wants to merge 1 commit intolcoutodemos:mainfrom
Open
feat: add native OS notifications with configurable trigger modes#34BennettSchwartz wants to merge 1 commit intolcoutodemos:mainfrom
BennettSchwartz wants to merge 1 commit intolcoutodemos:mainfrom
Conversation
Show native notifications when tasks complete or fail, with click-to-focus support that switches to the relevant tab and expands it. Three notification modes (configurable in the settings popover): - Always: notify on every completion, even when viewing the app - Tab hidden: notify when the completed tab is not actively visible - Window hidden: notify only when the entire window is hidden (default) Changes: - Main process: notification dispatch with Electron Notification API, prompt tracking per tab, shouldNotify() gating by mode - Preload: onFocusTab, setNotificationMode, setActiveTab bridges - Renderer: useClaudeEvents wires focus-tab handler and syncs notification mode + active tab to main process - Theme store: persisted notificationMode setting - SettingsPopover: notification mode dropdown - Types: FOCUS_TAB, SET_NOTIFICATION_MODE, SET_ACTIVE_TAB IPC channels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan