-
Notifications
You must be signed in to change notification settings - Fork 27
Add DragonFly bootstrap support (ltsmaster) (/src/core/sys/posix) #111
Add DragonFly bootstrap support (ltsmaster) (/src/core/sys/posix) #111
Conversation
|
Go ahead and update this to the latest version that got merged upstream and I'll pull it. |
7e48091 to
d06a232
Compare
|
@joakim-noah : Rebase and synced with dlang/PR/2001 |
joakim-noah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions.
src/core/sys/posix/pthread.d
Outdated
|
|
||
| enum PTHREAD_MUTEX_INITIALIZER = null; | ||
| //enum PTHREAD_ONCE_INIT = { PTHREAD_NEEDS_INIT, NULL }; | ||
| enum PTHREAD_ONCE_INIT = pthread_once_t.init;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete one semi-colon, missed this upstream too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
src/core/sys/posix/pthread.d
Outdated
| PTHREAD_MUTEX_ERRORCHECK = 1, | ||
| PTHREAD_MUTEX_RECURSIVE = 2, | ||
| PTHREAD_MUTEX_NORMAL = 3, | ||
| PTHREAD_MUTEX_ADAPTIVE_NP = 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't there upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed PTHREAD_MUTEX_ADAPTIVE_NP = 4,
Thanks !
| int shmdt(in void*); | ||
| int shmget(key_t, size_t, int); | ||
| } | ||
| else version( DragonFlyBSD ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither is this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh... but it should be (will amend dlang/druntime). Thanks for noticing this one !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dlang#2106 has been approved => waiting to be merged
82fad9e to
1b7484d
Compare
Synced with dlang/PR/2001
675f9b3 to
371046a
Compare
|
@joakim-noah Thanks for review and merging ! |
All druntime:/src/core/sys/posix/ files
Related PR's:
ldc
dlang: