Skip to content

fix concat for value arrays #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azahnen merged 1 commit into from
Oct 31, 2025
Merged

fix concat for value arrays #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...va/de/ii/xtraplatform/features/domain/transform/FeaturePropertyTokenSliceTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ default List<Object> transformValueArray(List<String> path, List<Object> slice)
return transformed;
}

default List<Object> transformValues(List<String> path, List<Object> slice) {
default List<Object> transformValues(List<String> path, boolean isArray, List<Object> slice) {
if (slice.isEmpty()) {
return slice;
}
Expand All @@ -149,7 +149,7 @@ default List<Object> transformValues(List<String> path, List<Object> slice) {

List<Object> before = slice.subList(0, min);
List<Object> after = slice.subList(max + 1, slice.size());
boolean inArray = before.contains(FeatureTokenType.ARRAY);
boolean inArray = isArray || before.contains(FeatureTokenType.ARRAY);
List<Object> transformed = new ArrayList<>();

transformed.addAll(before);
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/de/ii/xtraplatform/features/domain/transform/FeaturePropertyTransformerConcat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public List<Object> transform(String currentPropertyPath, List<Object> slice) {
}

if (!isObject()) {
return transformValues(schema.getFullPath(), slice);
return transformValues(schema.getFullPath(), schema.isArray(), slice);
}

int min = findFirst(slice, pathAsList(currentPropertyPath), 0);
Expand Down