Skip to content

Conversation

@cportele
Copy link
Contributor

@cportele cportele commented Nov 20, 2025

Closes ldproxy/ldproxy#1514.

Note that Oracle WKB differs in two aspects from standard WKB for these geometry types:

  1. CIRCULARSTRING, COMPOUNDCURVE, CURVEPOLYGON, MULTICURVE, and MULTISURFACE have a different geometry type code.
  2. The embedded geometries do not repeat the endian byte for COMPOUNDCURVE and CURVEPOLYGON.

Note that Oracle WKB differs in two aspects from standard WKB:

1. CIRCULARSTRING, COMPOUNDCURVE, CURVEPOLYGON, MULTICURVE, and MULTISURFACE have a different geometry type code.
2. The embedded geometries do not repeat the endian byte for COMPOUNDCURVE, CURVEPOLYGON, MULTICURVE, MULTISURFACE.
@cportele cportele requested a review from azahnen as a code owner November 20, 2025 12:51
@cportele
Copy link
Contributor Author

@azahnen - See the FeatureProviderSql: Do you see a better way to pass the information that a WKB blob is an Oracle WKB blob to the decoder?

@azahnen
Copy link
Collaborator

azahnen commented Nov 24, 2025

@cportele
I see two options:

  1. this instanceof FeatureProviderOracle would at least be more resilient against refactorings.
  2. Maybe the cleanest option would be to override getDecoder in FeatureProviderOracle, or to introduce a new method createDecoder that only contains the constructor call and override that.

Otherwise, this looks good to me and can be merged.

@cportele
Copy link
Contributor Author

@azahnen

Option 1 does not work as it would require that xtraplatform-features depends on xtraplatform-features-oracle. I will have a look into option 2.

@cportele cportele merged commit eb21cc3 into master Nov 26, 2025
3 checks passed
@cportele cportele deleted the oracle-arcs branch November 26, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oracle: support circular arcs

3 participants