refactor: port to *Lua* v5.4 #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I just realized that Neovim is still on Lua v5.1. So in that case this PR doesn't need to be merged, at least not now. |
Owner
|
I won't be able to accept this PR as is, this library is intentionally designed to work in environments with LuaJIT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the plugin! I ported this to Lua v5.4, so I can use https://github.com/3rd/image.nvim for https://github.com/benlubas/molten-nvim.
I switched to the CFFI library q66/cffi-lua: A portable C FFI for Lua 5.1+.
I tested this via
make test. All tests pass.I haven't tested this on GraphicsMagick, but made the same changes.
Hope you have time to look at this.