Skip to content

Modulization#164

Open
lzy0505 wants to merge 8 commits intoleanprover-community:masterfrom
lzy0505:use-module-system
Open

Modulization#164
lzy0505 wants to merge 8 commits intoleanprover-community:masterfrom
lzy0505:use-module-system

Conversation

@lzy0505
Copy link
Collaborator

@lzy0505 lzy0505 commented Mar 2, 2026

Description

  • Added module keyword at the top of each file
  • All import statements became public import (except for Proof Mode files)
  • Files with definitions/commands got @[expose] public section
  • The content of each Proof Mode file was split into a section and a meta section for helper lemmas and meta-programs
  • Tightened imports for Proof Mode files

Closes #121

I believe there’s still room for tightening visibility by removing public, which I only did for Proof Mode.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@lzy0505 lzy0505 marked this pull request as ready for review March 2, 2026 14:26
@markusdemedeiros
Copy link
Collaborator

Nice, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module-ize Iris-Lean

2 participants