Skip to content

chore: bump toolchain to v4.28.0-rc1 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kim-em merged 3 commits into from
Jan 26, 2026
Merged

chore: bump toolchain to v4.28.0-rc1 #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7f3614
chore: bump toolchain to v4.28.0-rc1
kim-em Jan 26, 2026
56eac19
fix: revert sorry message format to backticks
kim-em Jan 26, 2026
ea6353a
fix: revert all sorry message formats to backticks
kim-em Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lean-toolchain
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
leanprover/lean4:v4.27.0
leanprover/lean4:v4.28.0-rc1
22 changes: 11 additions & 11 deletions test/Mathlib/lake-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@
"type": "git",
"subDir": null,
"scope": "",
"rev": "a3a10db0e9d66acbebf76c5e6a135066525ac900",
"rev": "5352afccd6866369be9de43f5b7ec47203555f44",
"name": "mathlib",
"manifestFile": "lake-manifest.json",
"inputRev": "v4.27.0",
"inputRev": "v4.28.0-rc1",
"inherited": false,
"configFile": "lakefile.lean"},
{"url": "https://github.com/leanprover-community/plausible",
"type": "git",
"subDir": null,
"scope": "leanprover-community",
"rev": "009dc1e6f2feb2c96c081537d80a0905b2c6498f",
"rev": "7311586e1a56af887b1081d05e80c11b6c41d212",
"name": "plausible",
"manifestFile": "lake-manifest.json",
"inputRev": "main",
Expand All @@ -35,7 +35,7 @@
"type": "git",
"subDir": null,
"scope": "leanprover-community",
"rev": "8f497d55985a189cea8020d9dc51260af1e41ad2",
"rev": "875ad9d88ed684e39c16bdea260e6ecfa15afd60",
"name": "importGraph",
"manifestFile": "lake-manifest.json",
"inputRev": "main",
Expand All @@ -45,17 +45,17 @@
"type": "git",
"subDir": null,
"scope": "leanprover-community",
"rev": "c04225ee7c0585effbd933662b3151f01b600e40",
"rev": "6d65c6e0a25b8a52c13c3adeb63ecde3bfbb6294",
"name": "proofwidgets",
"manifestFile": "lake-manifest.json",
"inputRev": "v0.0.85",
"inputRev": "v0.0.86",
"inherited": true,
"configFile": "lakefile.lean"},
{"url": "https://github.com/leanprover-community/aesop",
"type": "git",
"subDir": null,
"scope": "leanprover-community",
"rev": "cb837cc26236ada03c81837bebe0acd9c70ced7d",
"rev": "f08e838d4f9aea519f3cde06260cfb686fd4bab0",
"name": "aesop",
"manifestFile": "lake-manifest.json",
"inputRev": "master",
Expand All @@ -65,7 +65,7 @@
"type": "git",
"subDir": null,
"scope": "leanprover-community",
"rev": "bd58c9efe2086d56ca361807014141a860ddbf8c",
"rev": "23324752757bf28124a518ec284044c8db79fee5",
"name": "Qq",
"manifestFile": "lake-manifest.json",
"inputRev": "master",
Expand All @@ -75,7 +75,7 @@
"type": "git",
"subDir": null,
"scope": "leanprover-community",
"rev": "b25b36a7caf8e237e7d1e6121543078a06777c8a",
"rev": "cabbb5a025bfbbc50af9184ed2dfdde6ea4f53a7",
"name": "batteries",
"manifestFile": "lake-manifest.json",
"inputRev": "main",
Expand All @@ -85,10 +85,10 @@
"type": "git",
"subDir": null,
"scope": "leanprover",
"rev": "55c37290ff6186e2e965d68cf853a57c0702db82",
"rev": "28e0856d4424863a85b18f38868c5420c55f9bae",
"name": "Cli",
"manifestFile": "lake-manifest.json",
"inputRev": "v4.27.0",
"inputRev": "v4.28.0-rc1",
"inherited": true,
"configFile": "lakefile.toml"}],
"name": "«repl-mathlib-tests»",
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/lakefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defaultTargets = ["ReplMathlibTests"]
[[require]]
name = "mathlib"
git = "https://github.com/leanprover-community/mathlib4"
rev = "v4.27.0"
rev = "v4.28.0-rc1"

[[lean_lib]]
name = "ReplMathlibTests"
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/lean-toolchain
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
leanprover/lean4:v4.27.0
leanprover/lean4:v4.28.0-rc1
2 changes: 1 addition & 1 deletion test/Mathlib/test/20240209.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Incomplete: contains sorry",
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/test/H20231115.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/test/H20231115_2.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

2 changes: 1 addition & 1 deletion test/Mathlib/test/H20231215_2.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 30},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

4 changes: 2 additions & 2 deletions test/Mathlib/test/exact.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 12},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Completed",
Expand All @@ -30,7 +30,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 12},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 2}

{"message":
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/test/file_env.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 3, "column": 8},
"endPos": {"line": 3, "column": 12},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"messages":
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/test/induction.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 11},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/test/line_breaks.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
[{"severity": "warning",
"pos": {"line": 3, "column": 8},
"endPos": {"line": 3, "column": 12},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

2 changes: 1 addition & 1 deletion test/Mathlib/test/on_goal.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"sorries":
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/test/pickle.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 25},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/Mathlib/test/placeholder_synthesis.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 2}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/app_type_mismatch.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/app_type_mismatch2.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/assumption_proof.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 10},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Completed", "proofState": 1, "goals": []}
Expand Down
2 changes: 1 addition & 1 deletion test/by_cases.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 11},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/calc.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

4 changes: 2 additions & 2 deletions test/dup_sorries.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 12},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"sorries":
Expand All @@ -19,6 +19,6 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 12},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

2 changes: 1 addition & 1 deletion test/have_by_sorry.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 11},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"sorries": [{"proofState": 2, "goal": "x : Int\n⊢ x = 1"}],
Expand Down
2 changes: 1 addition & 1 deletion test/invalid_tactic.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 18},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Incomplete: contains sorry",
Expand Down
2 changes: 1 addition & 1 deletion test/line_breaks.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 11},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"env": 1}
Expand Down
2 changes: 1 addition & 1 deletion test/name_generator.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 2, "column": 0},
"endPos": {"line": 2, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"sorries": [{"proofState": 1, "goal": "x : Int\nh0 : x > 0\n⊢ x > 0"}],
Expand Down
2 changes: 1 addition & 1 deletion test/pickle_open_scoped.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 7},
"endPos": {"line": 1, "column": 14},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 2}

{"env": 1}
Expand Down
2 changes: 1 addition & 1 deletion test/pickle_open_scoped_2.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 7},
"endPos": {"line": 1, "column": 14},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

2 changes: 1 addition & 1 deletion test/pickle_proof_state_1.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 4},
"endPos": {"line": 1, "column": 5},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/pickle_proof_state_env.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 4},
"endPos": {"line": 1, "column": 5},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/proof_branching.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 19},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/proof_branching2.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/proof_step.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 4},
"endPos": {"line": 1, "column": 5},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
4 changes: 2 additions & 2 deletions test/proof_transitivity.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Completed", "proofState": 1, "goals": []}
Expand All @@ -21,7 +21,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 0},
"endPos": {"line": 1, "column": 7},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus": "Completed", "proofState": 3, "goals": []}
Expand Down
2 changes: 1 addition & 1 deletion test/readme.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 4},
"endPos": {"line": 1, "column": 5},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 0}

{"proofStatus": "Incomplete: open goals remain",
Expand Down
2 changes: 1 addition & 1 deletion test/self_proof_apply_check.expected.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
[{"severity": "warning",
"pos": {"line": 1, "column": 8},
"endPos": {"line": 1, "column": 10},
"data": "declaration uses 'sorry'"}],
"data": "declaration uses `sorry`"}],
"env": 1}

{"proofStatus":
Expand Down
Loading