Skip to content

fix: ensure scalar offsets are BIR access patterns #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
govereau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure scalar offsets are BIR access patterns #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion KLR/Trace/Term.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,9 @@ nki builtin.access.ap
| .simple t =>
let pattern := pattern.map fun (s,c) => Core.APPair.mk s c 0
let scalarOffset <- scalar_offset.mapM fun
| .inl a => pure (.acc a)
| .inl a => do
Copy link
Copy Markdown
Collaborator

@ppotapov-aws ppotapov-aws Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind this triggers the bug in Walrus if we merge
I have a similar PR https://github.com/leanprover/KLR/pull/576/changes. Yours looks better

Copy link
Copy Markdown
Collaborator Author

@govereau govereau Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. Thanks for pointing out.

let ap <- a.toAP
pure (.acc $ .birPattern $ Core.BirAccessPattern.fromAccessPattern ap)
| .inr r => match r with
| .scalar s => pure (.reg s.toString)
| _ => throw s!"scalar_offset requires scalar argument, got {r.kindStr}"
Expand Down
Loading