feat: show target of links in in "elan show" #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing `elan show` after ``` elan toolchain link lean4-pgit /home/user/build/release/stage1 ``` the output now shows ``` installed toolchains -------------------- lean4 (linked to local path /home/user/build/release/stage1) leanprover/lean4:v4.22.0 leanprover/lean4:v4.23.0 (resolved from default 'stable') leanprover/lean4:v4.24.0-rc1 active toolchain ---------------- leanprover/lean4:v4.23.0 (resolved from default 'stable') Lean (version 4.23.0, x86_64-unknown-linux-gnu, commit 50aaf682e9b74ab92880292a25c68baa1cc81c87, Release) ``` with the novelty being the "(linked to local path /home/user/build/release/stage1)" message.
jcreedcmu
commented
Sep 17, 2025
| use crate::errors::*; | ||
| use crate::notifications::Notification; | ||
| use dirs; | ||
| use json; |
Contributor
Author
There was a problem hiding this comment.
this is just rustfmt, happy to remove if it's undesired noise
jcreedcmu
commented
Sep 17, 2025
| let releases = json::parse(&json) | ||
| .chain_err(|| format!("failed to parse release data: {}", url))?; | ||
| releases[channel][0]["name"].as_str() | ||
| let releases = |
Contributor
Author
There was a problem hiding this comment.
also just rustfmt
jcreedcmu
commented
Sep 17, 2025
| return Err(Error::from( | ||
| format!("channel 'beta' is not supported for custom origin '{}'", origin) | ||
| )); | ||
| return Err(Error::from(format!( |
Contributor
Author
There was a problem hiding this comment.
also just rustfmt
jcreedcmu
commented
Sep 17, 2025
| if let Some(path) = get_toolchain_local_target(&cfg, &t)? { | ||
| println!( | ||
| "{} (linked to local path {})", | ||
| &t, |
Contributor
Author
There was a problem hiding this comment.
Should this be mk_toolchain_label(&t, &default_tc, &resolved_default_tc) instead of just &t? I'm not sure about the potential for different decorations to overlap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
elan showafterthe output now shows
with the novelty being the
(linked to local path /home/user/build/release/stage1)message.