Skip to content

feat: min(?)/max(?) for Array #11936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
datokrat wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: min(?)/max(?) for Array #11936

datokrat wants to merge 10 commits into from

Conversation

@datokrat
Copy link
Contributor

@datokrat datokrat commented Jan 8, 2026 •
edited
Loading

This PR provides Array operations analogous to List.min(?) and List.max(?).

I had to prove a few auxiliary lemmas. Downstream in Batteries, which already had List.min and List.max, I renamed their variants to List.rangeMin and List.rangeMax in the PR testing branch. Their version is more general in the sense that it has start and stop autoParams, like Array.foldl has, but I think the futore belongs to Subarray.min instead (which I haven't implemented yet).

@datokrat datokrat added the changelog-library Library label Jan 8, 2026
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 8, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 8, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11936
8af6885
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jan 8, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11936
9bdf16f
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Jan 8, 2026
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jan 8, 2026
@leanprover-bot
Update lean-toolchain for testing leanprover/lean4#11936
60b07e2
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Jan 8, 2026 •
edited
Loading

Reference manual CI status:

@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Jan 8, 2026
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 8, 2026 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 8, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11936
95260d3
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jan 8, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11936
4a4959e
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jan 8, 2026
@leanprover-bot
Update lean-toolchain for leanprover/lean4#11936
88e46b9
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Jan 8, 2026
datokrat added a commit to datokrat/aesop that referenced this pull request Jan 12, 2026
@datokrat
adaptation for leanprover/lean4#11936
2d4a373
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Jan 12, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 12, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11936
5e9d1e5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jan 12, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11936
b7793ee
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jan 12, 2026
@leanprover-bot
Update lean-toolchain for leanprover/lean4#11936
2e0a743
@datokrat datokrat marked this pull request as ready for review January 12, 2026 22:42
@datokrat datokrat requested a review from kim-em as a code owner January 12, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@datokrat @leanprover-bot @leanprover-community-bot