perf: replay tactics when only trailing whitespace is changed #11958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!bench |
|
Benchmark results for d23b858 against d92cdae are in! @Kha Small changes (4🟥)
|
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 9, 2026
github-actions
bot
added
the
mathlib4-nightly-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 9, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jan 9, 2026
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
leanprover-community-bot
added
the
builds-mathlib
Collaborator
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the elaborator and language server so as not to rerun tactics when whitespace directly following them is changed, preventing loss of progress when starting to type the next tactic.
We do this by removing the trailing whitespace before passing a tactic from the tactic block elaborator to
evalTactic. The language server then reconstructs trailing whitespace from outer snapshot/info tree nodes when necessary.