-
Notifications
You must be signed in to change notification settings - Fork 733
feat: lemmas about sums of lists/arrays/vectors #11994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
datokrat
wants to merge
11
commits into
master
Choose a base branch
from
paul/humanevup1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 13, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 13, 2026
Collaborator
|
Mathlib CI status (docs):
|
Contributor
Author
|
!radar |
|
Benchmark results for 75e46e1 against e56351d are in! @datokrat Warnings (2)These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.
Small changes (2✅, 10🟥)
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 15, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 15, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 15, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 15, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 15, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 15, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 16, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-library
Library
mathlib4-nightly-available
A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides more lemmas about sums of lists/arrays/vectors, especially sums of
NatorIntlists/arrays/vectors.This change has been motivated by my experience solving
human-eval-leanproblems. Sums, minima and maxima are frequently required and the improvements provided in this PR make it easier to verify such programming tasks.Changes:
sumequalsfoldl/foldr.sum_append_natandsum_reverse_natlemmas so that they are polymorphic, requiring only some type class instances about the list elements' type. The polymorphic lemmas aren't simp- or grind-annotated because I fear the instance synthesis overhead. However, theNatandIntspecializations are annotated (see below). Note that as{Array,Vector}.mindo not exist, some lemmas can't be stated and were omitted.List.min_singletonandList.max_singletonlemmas as they were needed for some proofs.Nat-related:{List,Array,Vector}.sumlemmas that are specific forNatinto their own module:Init.Data.List.Nat.Sum,Init.Data.Array.NatandInt.Data.Vector.Nat.Nat.sum_pos_iff_exists_posand renamed it toList.sum_pos_iff_exists_pos_nat. This is more consistent and made it possible to addArrayandVectorvariants of this lemma.l.sum / l.lengthlies between the minimum and the maximum of a list.Intlists/arrays/vectors to parallel modules:Init.Data.List.Int.Sum,Init.Data.Array.IntandInt.Data.Vector.Int.sum_eq_sum_toListtosum_toList, which better represents the theorem's content.