-
Notifications
You must be signed in to change notification settings - Fork 8
chore: setup release-please for monorepo packages #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Publish TypeScript SDK | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| jobs: | ||
| publish: | ||
| if: startsWith(github.event.release.tag_name, 'sdks/typescript/') | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
| defaults: | ||
| run: | ||
| working-directory: sdks/typescript | ||
| steps: | ||
| - name: ⬇️ Checkout repo | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: 😻 Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 22 | ||
| registry-url: https://registry.npmjs.org | ||
|
|
||
| - name: 📥 Install dependencies | ||
| uses: bahmutov/npm-install@v1 | ||
| with: | ||
| working-directory: sdks/typescript | ||
|
|
||
| - name: 📦 Publish to npm | ||
| run: npm publish --provenance --access public | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,4 @@ | ||||||
| { | ||||||
| ".": "1.0.0" | ||||||
| } | ||||||
| "sdks/typescript": "0.2.0", | ||||||
| "evals/prompts": "1.2.0" | ||||||
|
||||||
| "evals/prompts": "1.2.0" | |
| "evals/prompts": "1.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this ☝️
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,4 @@ | ||||||||||||||||
| { | ||||||||||||||||
| "release-type": "simple", | ||||||||||||||||
| "include-v-in-tag": true, | ||||||||||||||||
| "pull-request-title-pattern": "chore${scope}: release${component} ${version}", | ||||||||||||||||
| "changelog-sections": [ | ||||||||||||||||
|
|
@@ -13,48 +12,52 @@ | |||||||||||||||
| "section": "Bug Fixes", | ||||||||||||||||
| "hidden": false | ||||||||||||||||
| }, | ||||||||||||||||
| { | ||||||||||||||||
| "type": "chore", | ||||||||||||||||
| "section": "Miscellaneous", | ||||||||||||||||
| "hidden": false | ||||||||||||||||
| }, | ||||||||||||||||
| { | ||||||||||||||||
| "type": "docs", | ||||||||||||||||
| "section": "Documentation", | ||||||||||||||||
| "hidden": false | ||||||||||||||||
| }, | ||||||||||||||||
| { | ||||||||||||||||
| "type": "perf", | ||||||||||||||||
| "section": "Performance Improvements", | ||||||||||||||||
| "hidden": false | ||||||||||||||||
| }, | ||||||||||||||||
| { | ||||||||||||||||
| "type": "test", | ||||||||||||||||
| "section": "Tests", | ||||||||||||||||
| "type": "revert", | ||||||||||||||||
| "section": "Reverts", | ||||||||||||||||
| "hidden": false | ||||||||||||||||
| }, | ||||||||||||||||
| { | ||||||||||||||||
| "type": "refactor", | ||||||||||||||||
| "section": "Code Refactoring", | ||||||||||||||||
| "type": "docs", | ||||||||||||||||
| "section": "Documentation", | ||||||||||||||||
| "hidden": false | ||||||||||||||||
| }, | ||||||||||||||||
| { | ||||||||||||||||
| "type": "deps", | ||||||||||||||||
| "type": "build", | ||||||||||||||||
|
||||||||||||||||
| "type": "build", | |
| "type": "build", | |
| "section": "Build System", | |
| "hidden": false | |
| }, | |
| { | |
| "type": "deps", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The publish job filter checks for tags starting with
sdks/typescript/, but release-please tags are typically generated with a hyphenated prefix (e.g.,sdks/typescript-v0.2.0) and/or the configuredcomponent(e.g.,typescript-sdk-v0.2.0). As written, this condition is likely to never match, so the SDK won’t publish on release. Update the prefix to match the actual tag format produced by your release-please configuration (or adjust the release-pleasecomponent/tag settings to emit the expected prefix).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this ☝️