Hotfix for anonymous Mail

[TamaroWalter]

Fixes problem adressed in #211, #202.

What was the problem?
It was a really funny problem. In the process of sending a notification mail of a new post, it's being checked twice (in different files and contexts) if the author of the post should be anonymous. Both checks function perfectly. The problem was, that the algorithm set the user-id to a negative integer after a first successful anonymous check. The second check works with the changed user-id integer and compares it to the original post user-id. Since the user-ids are not equal, the user was wrongly set as "non-anonymous". This happened especially in half-anonymous forums, as in those the anonymous status is being checked by user-id.

What is the solution?
After the first check, the anonymous status of the author is being saved in a variable. The second anonymous check is being replaced by simply checking the previous set variable.

Important!
This is only a hotfix. The email-system still needs a redesign that can be followed on #212.

[bluetom]

Please increase the version of this release like this:
old "version": 2025050600
new "version": 2025050601
old "release": 'v4.5-r1'
new "release": 'v4.5-r2'
And update file changes.md by adding:
4.5.1 (2025-05-17)
[HOTFIX] #214

[bluetom]

Sorry, there are still misunderstandings, I'm afraid. I try to make it clearer. Thank you!

Here the version.php lines exactly as I would like them to be (after Moodle standards):

$plugin->component = 'mod_moodleoverflow';
$plugin->version = 2025050601;
$plugin->requires = 2022112800;
$plugin->release = 'v4.5-r2';
$plugin->supported = [401, 405];
$plugin->maturity = MATURITY_STABLE;

In the changes.md file the sort order is usually from new to old:

4.5.1 (2025-05-19)

[HOTFIX] #214 Hotfix for anonymous Mail

4.5.0 (2025-05-06)

• Moodle 4.5 compatible version

[TamaroWalter]

Ahh I see. I never knew how the version.php should be done after the Moodle standards. I thought the version should be equal to the current date 😅.