Skip to content

Fix kernel oops #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9000h wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix kernel oops #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e1e305
fix kernel oops
9000h Feb 9, 2019
8fcb846
fix kernel oops
9000h Feb 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions vtunerc_ctrldev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ static long vtunerc_ctrldev_ioctl(struct file *file, unsigned int cmd,
{
struct vtunerc_ctx *ctx = file->private_data;
int len, i, vtype, ret = 0;
char buf[20];

if (ctx->closing)
return -EINTR;
Expand All @@ -179,7 +180,7 @@ static long vtunerc_ctrldev_ioctl(struct file *file, unsigned int cmd,
switch (cmd) {
case VTUNER_SET_NAME:
dprintk(ctx, "msg VTUNER_SET_NAME\n");
len = strlen((char *)arg) + 1;
len = sizeof((char *)arg);
ctx->name = kmalloc(len, GFP_KERNEL);
if (ctx->name == NULL) {
printk(KERN_ERR "vtunerc%d: no memory\n", ctx->idx);
Expand Down Expand Up @@ -207,22 +208,24 @@ static long vtunerc_ctrldev_ioctl(struct file *file, unsigned int cmd,

case VTUNER_SET_TYPE:
dprintk(ctx, "msg VTUNER_SET_TYPE\n");
if (strcasecmp((char *)arg, "DVB-S") == 0) {
len = sizeof((char *)arg);
copy_from_user(buf, (char *)arg, len);
if (strcasecmp(buf, "DVB-S") == 0) {
vtype = VT_S;
printk(KERN_NOTICE "vtunerc%d: setting DVB-S tuner vtype\n",
ctx->idx);
} else
if (strcasecmp((char *)arg, "DVB-S2") == 0) {
if (strcasecmp(buf, "DVB-S2") == 0) {
vtype = VT_S2;
printk(KERN_NOTICE "vtunerc%d: setting DVB-S2 tuner vtype\n",
ctx->idx);
} else
if (strcasecmp((char *)arg, "DVB-T") == 0) {
if (strcasecmp(buf, "DVB-T") == 0) {
vtype = VT_T;
printk(KERN_NOTICE "vtunerc%d: setting DVB-T tuner vtype\n",
ctx->idx);
} else
if (strcasecmp((char *)arg, "DVB-C") == 0) {
if (strcasecmp(buf, "DVB-C") == 0) {
vtype = VT_C;
printk(KERN_NOTICE "vtunerc%d: setting DVB-C tuner vtype\n",
ctx->idx);
Expand Down