Skip to content

Adds an ability to use preallocated memory instead of file#28

Open
erhoof wants to merge 2 commits intolecram:masterfrom
erhoof:feature/allocated-memory
Open

Adds an ability to use preallocated memory instead of file#28
erhoof wants to merge 2 commits intolecram:masterfrom
erhoof:feature/allocated-memory

Conversation

@erhoof
Copy link
Copy Markdown

@erhoof erhoof commented May 27, 2024

Speeds up execution on low-powered devices via USE_ALLOCATED_SPACE define

Also i added some c-style casts, to make possible compiling via C++ compiler

@paulmenzel
Copy link
Copy Markdown

Thank you for your contribution. Two minor comments. It’d be great if you added benchmark data to the commit message. Second, it’d be great if you used imperative mood in the commit message summary/title.

@Voidless7125
Copy link
Copy Markdown

You have a RAM leak. Here's the fix:

    if (!emu_memory)
    {
        fclose(f); // Fix
        return -1;
    }

I checked with Cppcheck. (And tested and confirmed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants