Skip to content

perf: replace str_sub with str_byte #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: replace str_sub with str_byte #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/resty/http.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ local str_lower = string.lower
local str_upper = string.upper
local str_find = string.find
local str_sub = string.sub
local str_byte = string.byte
local tbl_concat = table.concat
local tbl_insert = table.insert
local ngx_encode_args = ngx.encode_args
Expand Down Expand Up @@ -38,6 +39,7 @@ local ipairs = ipairs
local pairs = pairs
local pcall = pcall
local type = type
local QUESTION_MARK = str_byte("?")


-- http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.1
Expand Down Expand Up @@ -316,7 +318,7 @@ local function _format_request(self, params)
query = ngx_encode_args(query)
end

if query ~= "" and str_sub(query, 1, 1) ~= "?" then
if query ~= "" and str_byte(query) ~= QUESTION_MARK then
query = "?" .. query
end

Expand Down