fix: restore resolve_data_path and skip JAX tests in FAST_CI#78
Open
fix: restore resolve_data_path and skip JAX tests in FAST_CI#78
Conversation
Two root causes of the fast-unit-tests CI failure:
1. tests/test_train_crypto_lora_sweep.py imports resolve_data_path from
scripts/train_crypto_lora_sweep but the function was removed from the
script, causing a collection-time ImportError. Add it back: it checks
data_root/stocks/<symbol>.csv first (mixed-hourly layout) then falls
back to data_root/<symbol>.csv.
2. tests/test_jax_{losses,policy,trainer_wandboard}.py import jax/flax
which are not in requirements-ci.txt, so they fail to collect on
GitHub-hosted runners. Add all three to _FAST_CI_SKIP so
pytest_ignore_collect bypasses them when FAST_CI=1.
All 78 unit tests now pass cleanly under the CI environment variables.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
Codex Infinity Start a task on this PR's branch by commenting:
Tasks and logs: https://codex-infinity.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
resolve_data_pathinscripts/train_crypto_lora_sweep.py: the function was removed from the script buttests/test_train_crypto_lora_sweep.pystill imported it, causing a collection-timeImportErrorthat blocked the entire fast-unit-tests job. The function is re-added; it checksdata_root/stocks/<symbol>.csvfirst (common mixed-hourly layout) then falls back todata_root/<symbol>.csv.Skip JAX/Flax tests in FAST_CI:
tests/test_jax_losses.py,tests/test_jax_policy.py, andtests/test_jax_trainer_wandboard.pyimportjaxandflaxwhich are not inrequirements-ci.txt. These three files now appear in_FAST_CI_SKIPsopytest_ignore_collectbypasses them whenFAST_CI=1.Test plan
unittests pass locally under full CI env vars (CI=1 FAST_CI=1 CPU_ONLY=1 FAST_SIMULATE=1 …)tests/test_train_crypto_lora_sweep.py::test_resolve_data_path_supports_mixed_hourly_rootpasses🤖 Generated with Claude Code