feat: Add dynamic-height virtualization #299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scdekov Thank you so much! This is a great feature. However, I've noticed a problem with this commit: component rendering becomes sluggish when the browser viewport width changes, such as by dragging and resizing the browser. Could you help fix this? The latest version doesn't have this lag; see https://leezng.github.io/vue-json-pretty/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds opt-in support for variable-height rows when virtual is enabled. It measures rendered rows, maintains cumulative offsets, and uses binary search to map scrollTop to item indices, ensuring smooth, accurate scrolling even when content wraps or custom renders change row height.
The main motivation is to allow showing longer json string values wrapped so that they're more readable compared to having a long horizontal scroll when using virtual scrolling.
closes: #286