initialized history of base_iterative in __init__ [TINY] [FIX]#132
Open
daknuett wants to merge 1 commit intolehner:masterfrom
Open
initialized history of base_iterative in __init__ [TINY] [FIX]#132daknuett wants to merge 1 commit intolehner:masterfrom
daknuett wants to merge 1 commit intolehner:masterfrom
Conversation
…orithms are not used yet, the history should be empty, not non-existing
daknuett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterative algorithm instances are created but not used, the history attribute is missing; this can yield unexpected attribute errors. Setting the history to an empty list in
__init__avoids that.