Distinguish publication and updated date in feed items#43
Open
sunarch wants to merge 1 commit intolektor:masterfrom
Open
Distinguish publication and updated date in feed items#43sunarch wants to merge 1 commit intolektor:masterfrom
sunarch wants to merge 1 commit intolektor:masterfrom
Conversation
|
is there a reason why this merge has not been accepted? seems to work fine and as intended, as well as not breaking anything else, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be useful if both
publishedandupdateddates could be added to feed items, not just theupdatedfield.I added the new field to the tests but wasn't able to run them properly because the current master produces
FileNotFoundErrors on the feeds and that is beyond this scope.Reference feedgenerator
pubdatehere:https://github.com/django/django/blob/stable/5.2.x/django/utils/feedgenerator.py#L472