fix(carrier): [PCMT-1386] Add fallback for empty valid method MKTP#75
Open
michaelmaslengow wants to merge 2 commits intomainfrom
Open
fix(carrier): [PCMT-1386] Add fallback for empty valid method MKTP#75michaelmaslengow wants to merge 2 commits intomainfrom
michaelmaslengow wants to merge 2 commits intomainfrom
Conversation
Added fallback logic to match carrierMethod against carrier mapping when no shipping methods are available and carrier is available.
arnaud-hours
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fallback logic to match carrierMethod against carrier mapping when no shipping methods are available and valid carrier is available.
New workflow:
getCarrierId()
│
├─► Semantic Search (if option activée)
│ ├─► carrierMethod (if !hasShippingMethods)
│ └─► carrierName (if !hasCarriers)
│
├─► Manual Carrier Matching with carrierName (if hasCarriers)
│ ├─► by name
│ └─► by label
│
├─► Method Matching (si hasShippingMethods)
│ └─► via LengowMethod + carrier mapping
│
├─► ★ New: Method as Carrier Fallback
│ │ Conditions: hasCarriers && !hasShippingMethods && carrierMethod && !carrierName
│ └─► getCarrierIdByMethodAsCarrierFallback()
│ ├─► carrierMethod vs carrier marketplace name
│ ├─► carrierMethod vs carrier marketplace label
│ └─► carrierMethod vs all mapped carriers
│
└─► Default Carrier