Skip to content

feat: template#22

Open
pichoemr wants to merge 14 commits intomainfrom
template
Open

feat: template#22
pichoemr wants to merge 14 commits intomainfrom
template

Conversation

@pichoemr
Copy link

#__

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I included unit tests that cover my changes
  • I added/updated the documentation about my changes
  • I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

@pichoemr pichoemr self-assigned this Nov 14, 2022
@pichoemr pichoemr added the enhancement New feature or request label Nov 15, 2022
@jonas-martinez jonas-martinez changed the title [WIP] feat: template feat: template Nov 22, 2022
jonas-martinez
jonas-martinez previously approved these changes Nov 22, 2022
@taorepoara
Copy link
Member

I made some changes, but I think it needs more modification.

I'm not fond of the fact that it's the only template with the generated classes from the JSON Schema... I think that we should do without it.

@pichoemr
Copy link
Author

@taorepoara We can do without the generated class with the Json object

@taorepoara
Copy link
Member

We will first create a components lib just like the JavaScript one.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 🟤 Can wait

Development

Successfully merging this pull request may close these issues.

3 participants